No description
Find a file
Simon McVittie a0f8774a70 Get uninstalled libraries from environment in preference to ELF headers
Introspecting the dynamic headers is low-level and full of implementation
details.

It seems that gnome-shell was assuming the address of the string table is
given by taking the DT_STRTAB dynamic symbol table's value (d_un.d_val)
and casting it to an absolute pointer. However, in some environments
(apparently including Debian mips64el) the DT_STRTAB dynamic symbol
table's d_un.d_val can be merely an offset relative to the base address
of the executable in memory. The base address would have to be parsed from
a different ELF header, which as far as I know is not part of _DYNAMIC.

Rather than trying to look up the Shell executable's base address using
dlinfo() or similar, during unit testing it seems easier to pass in the
uninstalled library search path in the environment, along with other
uninstalled paths that we are going to need anyway.

The reason given for not using GI_TYPELIB_PATH in commit 9bc89b82
"main: Prepend RPATH or RUNPATH paths to gir search paths" was that
g_irepository_prepend_library_path() takes precedence, but we can easily
define our own environment variable that takes even higher precedence.
If it's set, we might as well also bypass the PKGLIBDIR, since while
running uninstalled we *only* want to use the uninstalled libraries.

When not running unit tests, it's desirable to make
`./build/src/gnome-shell` something you can run directly, so continue
to parse the ELF headers - but only on x86_64, where we're reasonably
confident that it works and any regressions with a newer glibc will
be noticed promptly.

Resolves: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6877
Bug-Debian: https://bugs.debian.org/1042980
Signed-off-by: Simon McVittie <smcv@debian.org>
2023-08-04 20:17:43 +00:00
.gitlab/issue_templates gitlab: Add a comment about disabling extension to the issue template 2022-12-15 19:07:08 +00:00
.gitlab-ci ci: Don't install fake pkexec in toolbox image 2023-07-23 11:42:56 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data style: Fix colored indicators lacking style in the overview 2023-08-02 20:05:39 +00:00
docs/reference docs: Remove invalid XInclude 2023-04-24 10:55:40 +08:00
js panel: Fix drawing functions for light theme 2023-08-02 20:05:39 +00:00
lint extensionUtils: Split out extension convenience functions 2023-07-15 13:16:42 +02:00
man man: Update options 2020-12-28 02:25:17 +01:00
meson theme: Include both dark and light variant in resource 2023-05-25 17:10:53 +02:00
po Update Portuguese translation 2023-08-04 15:49:07 +00:00
src Get uninstalled libraries from environment in preference to ELF headers 2023-08-04 20:17:43 +00:00
subprojects extension-tool: Use Extension base class in templates 2023-07-30 10:29:44 +03:00
tests Get uninstalled libraries from environment in preference to ELF headers 2023-08-04 20:17:43 +00:00
tools tools/create-toolbox: Allow setting up support for GNOME Classic 2023-05-16 18:20:42 +00:00
.eslintrc.yml extensions/internals: Port to ESM 2023-07-15 13:16:42 +02:00
.gitignore Ignore eslint cache files 2023-03-01 15:55:40 +00:00
.gitlab-ci.yml Bump mutter image 2023-08-02 14:20:22 +02:00
.gitmodules git: Always use libgnome-volume-control submodule from GNOME group 2022-08-04 18:31:16 +02:00
.jscheckignore ci: Don't ignore init.js 2023-04-21 18:28:32 +00:00
config.h.meson shell: Add device monitor for cameras 2023-07-29 13:55:15 +03:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap gnome-shell.doap: Make marge-bot a maintainer 2020-11-17 17:29:56 +00:00
HACKING.md js: Split gi imports to be on new lines to prepare for ES modules 2023-06-21 04:50:33 -07:00
meson.build shell: Add device monitor for cameras 2023-07-29 13:55:15 +03:00
meson_options.txt shell: Add device monitor for cameras 2023-07-29 13:55:15 +03:00
NEWS Bump version to 45.alpha 2023-07-06 19:23:10 +02:00
README.md doc: Update contribution section 2022-12-06 01:49:24 +01:00

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. If a merge request fixes an existing issue, it is good practice to append the full issue URL to each commit message. Try to always prefix commit subjects with a relevant topic, such as panel: or status/network:, and it's always better to write too much in the commit message body than too little.

Default branch

The default development branch is main. If you still have a local checkout under the old name, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.