edu4rdshl/gnome-shell
1
0
Fork 0
mirror of https://github.com/edu4rdshl/gnome-shell.git synced 2026-07-18 07:34:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
gnome-shell/js
History
Alessandro Bono 98f614b8fa appDisplay: Don't assume this._placeholder always exists 
Dropping a icon from the dash to the application grid will set this._placeholder
to null. However the AppIcon is still used to represent the application in the
application grid. If we click on it we emit a pressed event. Stop assuming
that this._placeholder is still valid in the callback, use the icon parameter
instead.

This fixes the following error:
```
Gjs-CRITICAL **: 18:22:39.003: JS ERROR: TypeError: this._placeholder is null
_ensurePlaceholder/<@resource:///org/gnome/shell/ui/appDisplay.js:1477:17
vfunc_button_press_event@resource:///org/gnome/shell/ui/appDisplay.js:3121:27
```

Fixes: 6fc93b78bc
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6317
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2606>
(cherry picked from commit ec6ab60e62)
2023-02-13 12:47:35 +01:00
..
dbusServices screencastService: Handle case where no videos directory exists 2023-02-13 12:47:14 +01:00
gdm cleanup: Use deepUnpack() intead of deep_unpack() 2022-08-10 10:29:24 +00:00
misc fileUtils: Do not follow symlinks 2023-02-13 12:45:53 +01:00
perf perf/basic: Toggle quick settings instead of old menu 2022-12-05 23:41:27 +01:00
portalHelper portalHelper: Switch to soup3-based WebKitGTK 2022-06-21 19:29:02 +00:00
ui appDisplay: Don't assume this._placeholder always exists 2023-02-13 12:47:35 +01:00
js-resources.gresource.xml status/power: Merge with system indicator 2022-08-03 12:41:05 +00:00
meson.build extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
portal-resources.gresource.xml js/portal-resources: Add missing fileUtils to js path 2022-11-03 18:02:27 +00:00