From ef04a9d1ed1d8ecad023fe7adb39baa521ec1551 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Sat, 3 May 2014 21:12:29 +0200 Subject: [PATCH] osdWindow: Check monitor validity before updating When a monitor is removed, the OsdWindow for that monitor may process the monitors-changed signal before OsdWindowManager does (which will remove the OSD). If that happens, we will currently try to access an invalid monitor; check for this to avoid a couple of warning. --- js/ui/osdWindow.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/js/ui/osdWindow.js b/js/ui/osdWindow.js index 6263070d1..bcdc39180 100644 --- a/js/ui/osdWindow.js +++ b/js/ui/osdWindow.js @@ -192,6 +192,8 @@ const OsdWindow = new Lang.Class({ _monitorsChanged: function() { /* assume 110x110 on a 640x480 display and scale from there */ let monitor = Main.layoutManager.monitors[this._monitorIndex]; + if (!monitor) + return; // we are about to be removed let scalew = monitor.width / 640.0; let scaleh = monitor.height / 480.0;