windowManager: Keep dim effect in overview

Removing the effect dates back to the time when we didn't show
attached dialogs in the overview. Since we do show attached
dialogs as such nowadays, it makes sense to keep the effect.

Close https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6265

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3151>
(cherry picked from commit 7b4054564e)
This commit is contained in:
Florian Müllner 2024-01-29 21:12:44 +01:00
parent 628ad639a4
commit d21e3485c9

View file

@ -512,8 +512,6 @@ export class WindowManager {
this._resizePending = new Set();
this._destroying = new Set();
this._dimmedWindows = [];
this._skippedActors = new Set();
this._allowedKeybindings = {};
@ -876,15 +874,6 @@ export class WindowManager {
IBusManager.getIBusManager().restartDaemon();
});
Main.overview.connect('showing', () => {
for (let i = 0; i < this._dimmedWindows.length; i++)
this._undimWindow(this._dimmedWindows[i]);
});
Main.overview.connect('hiding', () => {
for (let i = 0; i < this._dimmedWindows.length; i++)
this._dimWindow(this._dimmedWindows[i]);
});
this._windowMenuManager = new WindowMenu.WindowMenuManager();
if (Main.sessionMode.hasWorkspaces)
@ -1357,12 +1346,9 @@ export class WindowManager {
if (shouldDim && !window._dimmed) {
window._dimmed = true;
this._dimmedWindows.push(window);
this._dimWindow(window);
} else if (!shouldDim && window._dimmed) {
window._dimmed = false;
this._dimmedWindows =
this._dimmedWindows.filter(win => win !== window);
this._undimWindow(window);
}
}
@ -1491,10 +1477,6 @@ export class WindowManager {
_destroyWindow(shellwm, actor) {
let window = actor.meta_window;
window.disconnectObject(actor);
if (window._dimmed) {
this._dimmedWindows =
this._dimmedWindows.filter(win => win !== window);
}
if (window.is_attached_dialog())
this._checkDimming(window.get_transient_for());