edu4rdshl/gnome-shell
1
0
Fork 0
mirror of https://github.com/edu4rdshl/gnome-shell.git synced 2026-07-17 23:24:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

popupMenu: Use connectObject to disconnect when parent destroyed

Browse source 
Currently the handler is leaked, contributing to
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7143 , by using
`connectObject` with the `owner` actor we avoid leaking `PopupMenuManager`s
for things like the password entry in `AuthenticationDialog`

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7143
This commit is contained in:
Zander Brown 2023-10-28 04:39:46 +01:00
parent fe292ac941
commit b6e2836c17
No known key found for this signature in database
GPG key ID: 25EE3C36E31E5F84
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
js/ui/popupMenu.js
View file

@ -1276,7 +1276,7 @@ export class PopupMenuManager {
constructor(owner, grabParams) { constructor(owner, grabParams) {
this._grabParams = Params.parse(grabParams, this._grabParams = Params.parse(grabParams,
{actionMode: Shell.ActionMode.POPUP}); {actionMode: Shell.ActionMode.POPUP});
global.stage.connect('notify::key-focus', () => { global.stage.connectObject('notify::key-focus', () => {
if (!this.activeMenu) if (!this.activeMenu)
return; return;
@ -1285,7 +1285,7 @@ export class PopupMenuManager {
if (newMenu) if (newMenu)
this._changeMenu(newMenu); this._changeMenu(newMenu);
}); }, owner);
this._menus = []; this._menus = [];
} }