edu4rdshl/gnome-shell
1
0
Fork 0
mirror of https://github.com/edu4rdshl/gnome-shell.git synced 2026-07-18 07:34:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

messageTray: Don't play sound when banners are disabled

Browse source 
When support for notification sounds was added, it made some sense
to keep the 'enable-sound' setting independent from 'show-banners'.

However that changed when 'show-banners' was rebranded in the UI as
"Do Not Disturb", as sounds are at least as disturbing as the banners.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2873

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1814>
This commit is contained in:
Florian Müllner 2020-10-27 01:03:43 +01:00 • committed by Vadym Kurachevskyi
parent 21d291b6a7
commit 8c19cd528a
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
js/ui/messageTray.js
View file

@ -855,8 +855,6 @@ var Source = GObject.registerClass({
if (this.policy.showBanners || notification.urgency == Urgency.CRITICAL)
this.emit('notification-show', notification);
else
notification.playSound();
}
notify(propName) {