edu4rdshl/gnome-shell
1
0
Fork 0
mirror of https://github.com/edu4rdshl/gnome-shell.git synced 2026-07-18 07:34:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

swipeTracker: Allow to specify a bump range

Browse source 
Right now, given the snap points [0, 1, 2] we can't go below 0 or above 2
during the swipe update. In order to give more feedback during the swipe
sometimes it is useful to move the content even when we already reached
the first or the latest snap point. Address this by adding a bump range.
With a bump range specified, the gesture progress update is not limited
by the snap points boundaries. For example, with snap points [0, 1, 2]
and a bumpRange 0.1, the update swipe progress value can now be between
-0.1 and 2.1.
This commit is contained in:
Alessandro Bono 2022-11-12 14:20:07 +01:00
parent b0fbf0570f
commit 891243c62a
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
js/ui/swipeTracker.js
View file

@ -647,6 +647,11 @@ export const SwipeTracker = GObject.registerClass({
return [this._snapPoints[lowerIndex], this._snapPoints[upperIndex]];
}
_getBoundsWithBumpRange(pos) {
const bounds = this._getBounds(pos);
return [bounds[0] - this._bumpRange, bounds[1] + this._bumpRange];
}
_updateGesture(gesture, time, delta, distance) {
if (this._state !== State.SCROLLING)
return;
@ -663,7 +668,7 @@ export const SwipeTracker = GObject.registerClass({
this._progress += delta / distance;
this._history.append(time, delta);
this._progress = Math.clamp(this._progress, ...this._getBounds(this._initialProgress));
this._progress = Math.clamp(this._progress, ...this._getBoundsWithBumpRange(this._initialProgress));
this.emit('update', this._progress);
}
@ -758,13 +763,16 @@ export const SwipeTracker = GObject.registerClass({
* @param {number[]} snapPoints - An array of snap points, sorted in ascending order
* @param {number} currentProgress - initial progress value
* @param {number} cancelProgress - the value to be used on cancelling
* @param {number} bumpRange - how much the user can stretch beyond the first or
* the latest snap point
*/
confirmSwipe(distance, snapPoints, currentProgress, cancelProgress) {
confirmSwipe(distance, snapPoints, currentProgress, cancelProgress, bumpRange = 0) {
this.distance = distance;
this._snapPoints = snapPoints;
this._initialProgress = currentProgress;
this._progress = currentProgress;
this._cancelProgress = cancelProgress;
this._bumpRange = bumpRange;
this._state = State.SCROLLING;
}