edu4rdshl/gnome-shell
1
0
Fork 0
mirror of https://github.com/edu4rdshl/gnome-shell.git synced 2026-07-17 23:24:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

messageTray: Ensure _updateDatetimeId idle callback is cancelled

Browse source 
If the idle callback is not explicitly removed when the notification is
destroyed, it may be invoked after destruction, and try to modify the
notification after it’s been freed.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3352>
This commit is contained in:
Philip Withnall 2024-05-28 18:05:10 +01:00 • committed by Marge Bot
parent 37e49e8a22
commit 8176d6b51c
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
js/ui/messageTray.js
View file

@ -475,6 +475,11 @@ export class Notification extends GObject.Object {
destroy(reason = NotificationDestroyedReason.DISMISSED) {
this.emit('destroy', reason);
if (this._updateDatetimeId)
GLib.source_remove(this._updateDatetimeId);
delete this._updateDatetimeId;
this.run_dispose();
}
}