From 4c5cb191d8780ca62affa035554f0565d1101c91 Mon Sep 17 00:00:00 2001 From: Sam Hewitt Date: Tue, 23 Jan 2024 14:11:27 -0330 Subject: [PATCH] style: Fix bg color weirdness on background apps close button Part-of: --- data/theme/gnome-shell-sass/widgets/_quick-settings.scss | 9 +++++++-- js/ui/status/backgroundApps.js | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/data/theme/gnome-shell-sass/widgets/_quick-settings.scss b/data/theme/gnome-shell-sass/widgets/_quick-settings.scss index df752aa47..c43081baf 100644 --- a/data/theme/gnome-shell-sass/widgets/_quick-settings.scss +++ b/data/theme/gnome-shell-sass/widgets/_quick-settings.scss @@ -198,9 +198,14 @@ icon-size: $large_icon_size !important; -st-icon-style: regular !important; } - & .close-button { - @extend .icon-button; + & .icon-button { padding: $base_padding; + + // override some background colors since it's a button on an already styled background + // FIXME: may need a generic drawing method for button in menu item in future + background-color: transparentize($fg_color, 0.87); + &:hover { background-color: transparentize($fg_color, 0.78);} + &:active { background-color: transparentize($fg_color, 0.69);} } & .spinner { padding: $base_padding; diff --git a/js/ui/status/backgroundApps.js b/js/ui/status/backgroundApps.js index fb457ae2d..6c4b80601 100644 --- a/js/ui/status/backgroundApps.js +++ b/js/ui/status/backgroundApps.js @@ -81,7 +81,7 @@ const BackgroundAppMenuItem = GObject.registerClass({ const closeButton = new St.Button({ iconName: 'window-close-symbolic', - styleClass: 'close-button', + styleClass: 'icon-button', x_expand: true, y_expand: false, x_align: Clutter.ActorAlign.END,