edu4rdshl/Strata
1
0
Fork 0
mirror of https://github.com/edu4rdshl/Strata.git synced 2026-07-18 07:34:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf: drop unused base64 return value from make_thumbnail

Browse source 
make_thumbnail was computing a base64 string of the thumbnail on every
image clipboard capture. The caller only ever used the raw bytes and
immediately discarded the String. Remove the base64 encode, simplify
the return type to Result<Vec<u8>>, and drop the now-unused
'use base64::Engine' import from main.rs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Eduard Tolosa 2026-05-25 03:41:30 -05:00
parent 86351cb22c
commit 805b14a0bd
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
strata-daemon/src/main.rs
View file

@ -6,7 +6,6 @@ mod dbus_service;
use std::sync::Arc;
use anyhow::{Context, Result};
use base64::Engine as _;
use dbus_service::{Limits, StrataManager, SubmitRequest, THUMB_PX};
use tokio::sync::{mpsc, Mutex};
use tracing_subscriber::EnvFilter;
@ -263,7 +262,7 @@ async fn process_bytes(
tokio::task::spawn_blocking(move || make_thumbnail(&raw_for_thumb, THUMB_PX)).await?;
let thumb_bytes = match thumb_result {
Ok((bytes, _b64)) => bytes,
Ok(bytes) => bytes,
Err(e) => {
tracing::warn!("Image thumbnail generation failed: {e}");
return Ok(());
@ -347,17 +346,13 @@ fn read_clipboard_bytes(mime: &str) -> Result<(Vec<u8>, String)> {
Ok((buf, actual_mime))
}
/// Generate a PNG thumbnail (≤`max_px`×`max_px`) from raw image bytes.
/// Returns `(thumbnail_bytes, base64_preview)`.
fn make_thumbnail(raw: &[u8], max_px: u32) -> Result<(Vec<u8>, String)> {
/// Generate a PNG thumbnail (<=`max_px`x`max_px`) from raw image bytes.
fn make_thumbnail(raw: &[u8], max_px: u32) -> Result<Vec<u8>> {
let img = image::load_from_memory(raw).context("Decoding image")?;
let thumb = img.thumbnail(max_px, max_px);
let mut out = Vec::new();
thumb
.write_to(&mut std::io::Cursor::new(&mut out), image::ImageFormat::Png)
.context("Encoding thumbnail")?;
let b64 = base64::engine::general_purpose::STANDARD.encode(&out);
Ok((out, b64))
Ok(out)
}